thwap/kronai
Watch
4
0
Fork
You've already forked kronai
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

refactor(mcp): add public name property to MCPServer #139

Merged
fuzzy merged 1 commit from fix/0097-mcp-name-property into main 2026-07-05 17:00:22 +00:00
Conversation 1 Commits 1 Files changed 2 +6 -1
automation commented 2026-07-05 16:54:47 +00:00
Owner
Copy link

What

Add a public name property to MCPServer and use it in engine.py instead of accessing the private _name attribute.

Why

Cleaner encapsulation — removes the # noqa: SLF001 suppression.

Testing

  • 145 unit tests pass
  • Pre-commit hooks pass

Closes #97

## What Add a public `name` property to `MCPServer` and use it in `engine.py` instead of accessing the private `_name` attribute. ## Why Cleaner encapsulation — removes the `# noqa: SLF001` suppression. ## Testing - [x] 145 unit tests pass - [x] Pre-commit hooks pass Closes #97
refactor(mcp): add public name property to MCPServer
Some checks failed
CI / test (pull_request) Successful in 54s
Details
CI / lint (pull_request) Has been cancelled
Details
9450b1fc16 
Replaces direct _name access (with noqa: SLF001) with a proper
@property, keeping the private attribute but exposing it cleanly.
Closes #97
fuzzy force-pushed fix/0097-mcp-name-property from 9450b1fc16
Some checks failed
CI / test (pull_request) Successful in 54s
Details
CI / lint (pull_request) Has been cancelled
Details
to 9f5519cf3a
All checks were successful
CI / test (pull_request) Successful in 51s
Details
CI / lint (pull_request) Successful in 1m19s
Details
2026-07-05 16:55:52 +00:00 Compare
the.auditor approved these changes 2026-07-05 16:59:42 +00:00
the.auditor left a comment
Copy link

Automated Review — PR #139

Result: APPROVED

Clean refactor — adds @property name to MCPServer and uses server.name instead of server._name in engine.py. Removes noqa: SLF001 suppression. Closes #97.

No suggestions.

## Automated Review — PR #139 **Result: APPROVED** --- Clean refactor — adds `@property name` to `MCPServer` and uses `server.name` instead of `server._name` in `engine.py`. Removes `noqa: SLF001` suppression. Closes #97. No suggestions.
fuzzy merged commit 9f5519cf3a into main 2026-07-05 17:00:22 +00:00
fuzzy deleted branch fix/0097-mcp-name-property 2026-07-05 17:00:22 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
the.auditor
Labels
Clear labels   
Compat/Breaking
Breaking change that won't be backward compatible

  
Kind/Bug
Something is not working

  
Kind/Documentation
Documentation changes

  
Kind/Enhancement
Improve existing functionality

  
Kind/Feature
New functionality

  
Kind/Security
This is security issue

  
Kind/Testing
Issue or pull request related to testing

  
Priority
Critical
 The priority is critical

  
Priority
High
 The priority is high

  
Priority
Low
 The priority is low

  
Priority
Medium
 The priority is medium

  
Reviewed
Confirmed
 Issue has been confirmed

  
Reviewed
Duplicate
 This issue or pull request already exists

  
Reviewed
Invalid
 Invalid issue

  
Reviewed
Won't Fix
 This issue won't be fixed

  
Status
Abandoned
 Somebody has started to work on this but abandoned work

  
Status
Blocked
 Something is blocking this issue or pull request

  
Status
Need More Info
 Feedback is required to reproduce issue or to continue work

No labels
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
thwap/kronai!139
No description provided.