thwap/kronai
Watch
4
0
Fork
You've already forked kronai
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix(cli): consistent exit codes on empty results #143

Merged
fuzzy merged 1 commit from fix/0102-consistent-exit-codes into main 2026-07-05 17:24:11 +00:00
Conversation 1 Commits 1 Files changed 2 +5 -5
automation commented 2026-07-05 17:02:53 +00:00
Owner
Copy link

What

_cmd_interval() now exits with code 1 when no jobs are found, matching the behavior of _cmd_run() on not-found.

Why

Consistent exit code behavior across subcommands.

Testing

  • 145 unit tests pass
  • Pre-commit hooks pass

Closes #102

## What `_cmd_interval()` now exits with code 1 when no jobs are found, matching the behavior of `_cmd_run()` on not-found. ## Why Consistent exit code behavior across subcommands. ## Testing - [x] 145 unit tests pass - [x] Pre-commit hooks pass Closes #102
fix(cli): consistent exit codes on empty results
Some checks failed
CI / lint (pull_request) Has been cancelled
Details
CI / test (pull_request) Has been cancelled
Details
4f2e9bbf6f 
_cmd_interval now exits 1 when no jobs found, matching the
behavior of _cmd_run on not-found.
Closes #102
fuzzy force-pushed fix/0102-consistent-exit-codes from 4f2e9bbf6f
Some checks failed
CI / lint (pull_request) Has been cancelled
Details
CI / test (pull_request) Has been cancelled
Details
to d16221fa39
Some checks failed
CI / test (pull_request) Has been cancelled
Details
CI / lint (pull_request) Has been cancelled
Details
2026-07-05 17:03:21 +00:00 Compare
fuzzy force-pushed fix/0102-consistent-exit-codes from d16221fa39
Some checks failed
CI / test (pull_request) Has been cancelled
Details
CI / lint (pull_request) Has been cancelled
Details
to 5bb581e8fb
All checks were successful
CI / test (pull_request) Successful in 46s
Details
CI / lint (pull_request) Successful in 1m18s
Details
2026-07-05 17:05:33 +00:00 Compare
the.auditor approved these changes 2026-07-05 17:10:39 +00:00
the.auditor left a comment
Copy link

Automated Review — PR #143

Result: APPROVED

One-line fix — _cmd_interval now exits with code 1 on empty results, matching _cmd_run behavior. Closes #102.

No suggestions.

## Automated Review — PR #143 **Result: APPROVED** One-line fix — `_cmd_interval` now exits with code 1 on empty results, matching `_cmd_run` behavior. Closes #102. No suggestions.
fuzzy force-pushed fix/0102-consistent-exit-codes from 5bb581e8fb
All checks were successful
CI / test (pull_request) Successful in 46s
Details
CI / lint (pull_request) Successful in 1m18s
Details
to 3d3631464f
All checks were successful
CI / test (pull_request) Successful in 48s
Details
CI / lint (pull_request) Successful in 1m19s
Details
2026-07-05 17:13:31 +00:00 Compare
fuzzy force-pushed fix/0102-consistent-exit-codes from 3d3631464f
All checks were successful
CI / test (pull_request) Successful in 48s
Details
CI / lint (pull_request) Successful in 1m19s
Details
to e08120c991
All checks were successful
CI / test (pull_request) Successful in 53s
Details
CI / lint (pull_request) Successful in 1m17s
Details
2026-07-05 17:20:11 +00:00 Compare
fuzzy merged commit e08120c991 into main 2026-07-05 17:24:11 +00:00
fuzzy deleted branch fix/0102-consistent-exit-codes 2026-07-05 17:24:11 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
the.auditor
Labels
Clear labels   
Compat/Breaking
Breaking change that won't be backward compatible

  
Kind/Bug
Something is not working

  
Kind/Documentation
Documentation changes

  
Kind/Enhancement
Improve existing functionality

  
Kind/Feature
New functionality

  
Kind/Security
This is security issue

  
Kind/Testing
Issue or pull request related to testing

  
Priority
Critical
 The priority is critical

  
Priority
High
 The priority is high

  
Priority
Low
 The priority is low

  
Priority
Medium
 The priority is medium

  
Reviewed
Confirmed
 Issue has been confirmed

  
Reviewed
Duplicate
 This issue or pull request already exists

  
Reviewed
Invalid
 Invalid issue

  
Reviewed
Won't Fix
 This issue won't be fixed

  
Status
Abandoned
 Somebody has started to work on this but abandoned work

  
Status
Blocked
 Something is blocking this issue or pull request

  
Status
Need More Info
 Feedback is required to reproduce issue or to continue work

No labels
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
thwap/kronai!143
No description provided.