refactor(status): replace raw dict with JobStatus dataclass #151

Merged
fuzzy merged 1 commit from fix/0115-use-jobstatus-dataclass into main 2026-07-05 17:53:58 +00:00
Owner

What

Replace raw dict[str, Any] usage in status.py with the JobStatus dataclass that was already defined in models.py but unused.

Why

Eliminates dead code — JobStatus was defined but never used. Now it's properly wired into load_status() and save_status().

Testing

  • 145 unit tests pass
  • Pre-commit hooks pass

Closes #115

## What Replace raw `dict[str, Any]` usage in `status.py` with the `JobStatus` dataclass that was already defined in `models.py` but unused. ## Why Eliminates dead code — `JobStatus` was defined but never used. Now it's properly wired into `load_status()` and `save_status()`. ## Testing - [x] 145 unit tests pass - [x] Pre-commit hooks pass Closes #115
refactor(status): replace raw dict with JobStatus dataclass
All checks were successful
CI / test (pull_request) Successful in 50s
CI / lint (pull_request) Successful in 1m21s
c5a42d32a7
load_status now returns a JobStatus object instead of a raw
dict, eliminating the dead JobStatus dataclass warning.
Closes #115
the.auditor left a comment

Automated Review — PR #151

Result: APPROVED


Clean refactor — wires the previously dead JobStatus dataclass into status.py. load_status() returns JobStatus instead of raw dict, save_status() uses asdict() for serialization. All callers updated to attribute access. Closes #115.

No suggestions.

## Automated Review — PR #151 **Result: APPROVED** --- Clean refactor — wires the previously dead `JobStatus` dataclass into `status.py`. `load_status()` returns `JobStatus` instead of raw dict, `save_status()` uses `asdict()` for serialization. All callers updated to attribute access. Closes #115. No suggestions.
fuzzy scheduled this pull request to auto merge when all checks succeed 2026-07-05 17:53:36 +00:00
fuzzy merged commit c5a42d32a7 into main 2026-07-05 17:53:58 +00:00
fuzzy deleted branch fix/0115-use-jobstatus-dataclass 2026-07-05 17:53:58 +00:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
thwap/kronai!151
No description provided.