refactor(status): replace raw dict with JobStatus dataclass #151
No reviewers
Labels
No labels
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
thwap/kronai!151
Loading…
Reference in a new issue
No description provided.
Delete branch "fix/0115-use-jobstatus-dataclass"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
What
Replace raw
dict[str, Any]usage instatus.pywith theJobStatusdataclass that was already defined inmodels.pybut unused.Why
Eliminates dead code —
JobStatuswas defined but never used. Now it's properly wired intoload_status()andsave_status().Testing
Closes #115
Automated Review — PR #151
Result: APPROVED
Clean refactor — wires the previously dead
JobStatusdataclass intostatus.py.load_status()returnsJobStatusinstead of raw dict,save_status()usesasdict()for serialization. All callers updated to attribute access. Closes #115.No suggestions.