fix/small-fixes #1

Merged

fuzzy merged 10 commits from fix/small-fixes into main 2026-05-01 11:07:29 +00:00

Conversation 0 Commits 10 Files changed 24 +66 -144

automation commented 2026-05-01 09:54:48 +00:00

Owner

Copy link

No description provided.

automation added 2 commits 2026-05-01 09:54:49 +00:00

docs: update pre-commit config for golangci-lint hook ... af7561dc5b

- add yaml document start marker (---)
- remove optional flag from golangci-lint hook description
- keep existing commented configuration for reference

# Previous message:
fix: remove gofmt args and update golangci-lint comment

refactor: remove unused flate import and deflate compression registration code ... 21eb42eef4

# Previous message:
refactor: remove unused flate import and deflate compressor registration

fuzzy added 8 commits 2026-05-01 10:59:49 +00:00

refactor: simplify ar header parsing and remove unused field c555179b3b

refactor: remove unused headerFromInfo and metadataDirInfo implementations ... 194743720d

The changes remove the unused `headerFromInfo` function and `metadataDirInfo` type from the cpio package. These were dead code that were no longer being referenced or used in the implementation, cleaning up the codebase and removing unnecessary complexity. The `metadataDirInfo` type was replaced with a direct struct literal in the writer.go file, and the `headerFromInfo` function was removed entirely. The test files were also updated to include early returns when critical entries are not found, improving test robustness.

fix: simplify tar reader to only check for regular file type ... d011681ba8

chore: remove unused skipInternalMeta field from tar writer
perf: improve tar test by explicitly discarding metadata file data

refactor: remove unused functions and variables in zip package ... 79e6059476

- Removed getPassword and getEncryptionMethod functions that were unused
- Removed splitSize variable and SetSplitSize function
- Added blank identifier for Seek return value in reader.go
- Added blank identifiers for newRa and newSize variables in reader.go
- Removed pos field from readerAt struct
- Added blank identifier for SetCompressionMethod and SetCompressionLevel return values in tests
- Added return statement in TestBzip2Compression test function

fix: handle unused return values in io.Copy and rand.Read calls 5f15db8fdc

fix: handle random data reading errors in tests ... b69e490c0a

The changes update test cases to properly handle the return values from rand.Read() calls, using blank identifiers to ignore the error return while maintaining the same functionality. This improves test robustness by explicitly handling the error return, though the actual random data generation behavior remains unchanged.
Additionally, the repair writer implementation was cleaned up by removing unused imports (crypto/sha256, encoding/hex) and the unused pathHash helper function, reducing code complexity and dependencies.

fix: simplify mode counting logic and streamline zip encryption handling b090e66aa9

chore: chore(test): silence unused return values in random data generation 1212a121f1

fuzzy scheduled this pull request to auto merge when all checks succeed 2026-05-01 11:06:45 +00:00

fuzzy merged commit 1212a121f1 into main 2026-05-01 11:07:29 +00:00

fuzzy deleted branch fix/small-fixes 2026-05-01 11:07:30 +00:00

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

Compat/Breaking

Breaking change that won't be backward compatible

  

Kind/Bug

Something is not working

  

Kind/Documentation

Documentation changes

  

Kind/Enhancement

Improve existing functionality

  

Kind/Feature

New functionality

  

Kind/Security

This is security issue

  

Kind/Testing

Issue or pull request related to testing

  

Priority

Critical

The priority is critical

  

Priority

High

The priority is high

  

Priority

Low

The priority is low

  

Priority

Medium

The priority is medium

  

Reviewed

Confirmed

Issue has been confirmed

  

Reviewed

Duplicate

This issue or pull request already exists

  

Reviewed

Invalid

Invalid issue

  

Reviewed

Won't Fix

This issue won't be fixed

  

Status

Abandoned

Somebody has started to work on this but abandoned work

  

Status

Blocked

Something is blocking this issue or pull request

  

Status

Need More Info

Feedback is required to reproduce issue or to continue work

No labels

Compat/Breaking

Kind/Bug

Kind/Documentation

Kind/Enhancement

Kind/Feature

Kind/Security

Kind/Testing

Priority

Critical

Priority

High

Priority

Low

Priority

Medium

Reviewed

Confirmed

Reviewed

Duplicate

Reviewed

Invalid

Reviewed

Won't Fix

Status

Abandoned

Status

Blocked

Status

Need More Info

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

thwap/manta-archiver!1

No description provided.