feat(config): warn on invalid environment variable values #123

New issue

Closed

opened 2026-07-13 17:21:27 +00:00 by the.auditor · 1 comment

the.auditor commented

2026-07-13 17:21:27 +00:00

Owner

internal/config/config.go:51-72 — applyEnvOverrides silently ignores invalid env var values.

If user sets PGET_CONCURRENCY=abc or PGET_TIMEOUT=not-a-duration, the invalid value is silently dropped and the flag default (or CLI flag value) is used instead.

Suggestion: log a warning to stderr when env var parsing fails, e.g.:

warning: invalid PGET_CONCURRENCY value "abc", ignoring

Discovered during review of PR #122.

`internal/config/config.go:51-72` — `applyEnvOverrides` silently ignores invalid env var values. If user sets `PGET_CONCURRENCY=abc` or `PGET_TIMEOUT=not-a-duration`, the invalid value is silently dropped and the flag default (or CLI flag value) is used instead. Suggestion: log a warning to stderr when env var parsing fails, e.g.: ``` warning: invalid PGET_CONCURRENCY value "abc", ignoring ``` Discovered during review of PR #122.

the.auditor added the

Kind/Enhancement

Priority

Low

labels

2026-07-13 17:21:31 +00:00

automation commented

2026-07-15 17:35:42 +00:00

Owner

Closing — implemented in PR #168. Invalid env var values now print a warning to stderr: "warning: invalid PGET_CONCURRENCY value "abc", ignoring"

Closing — implemented in PR #[168](https://git.lan.thwap.org/thwap/pget/pulls/168). Invalid env var values now print a warning to stderr: "warning: invalid PGET_CONCURRENCY value "abc", ignoring"

automation closed this issue

2026-07-15 17:35:46 +00:00