feat(config): warn on invalid environment variable values #168

Merged

fuzzy merged 1 commit from feature/warn-invalid-env into main

2026-07-15 17:40:32 +00:00

automation commented

2026-07-15 17:35:59 +00:00

Owner

What

When an environment variable has an unparseable value, print a warning to stderr instead of silently dropping it.

Why

Users setting PGET_CONCURRENCY=abc would silently fall back to the default or CLI flag, with no indication anything was wrong.

Implementation

Each parsing branch in applyEnvOverrides now has an else clause that prints:

warning: invalid PGET_CONCURRENCY value "abc", ignoring

Affected env vars: PGET_CONCURRENCY, PGET_RETRIES, PGET_TIMEOUT, PGET_QUIET, PGET_VERBOSE, PGET_RESUME, PGET_RATE.

Testing

Manual: PGET_CONCURRENCY=abc ./pget <url> prints warning
go test -race ./... — all pass
golangci-lint run — 0 issues

Breaking Changes

None

Closes #123

## What When an environment variable has an unparseable value, print a warning to stderr instead of silently dropping it. ## Why Users setting `PGET_CONCURRENCY=abc` would silently fall back to the default or CLI flag, with no indication anything was wrong. ## Implementation Each parsing branch in `applyEnvOverrides` now has an else clause that prints: ``` warning: invalid PGET_CONCURRENCY value "abc", ignoring ``` Affected env vars: PGET_CONCURRENCY, PGET_RETRIES, PGET_TIMEOUT, PGET_QUIET, PGET_VERBOSE, PGET_RESUME, PGET_RATE. ## Testing - [x] Manual: `PGET_CONCURRENCY=abc ./pget <url>` prints warning - [x] `go test -race ./...` — all pass - [x] `golangci-lint run` — 0 issues ## Breaking Changes None Closes #123

automation added 1 commit

2026-07-15 17:35:59 +00:00

feat(config): warn on invalid environment variable values

Test and Release / test (pull_request) Successful in 2m31s

Details

Test and Release / lint (pull_request) Successful in 3m37s

Details

ace1051397

applyEnvOverrides now prints a warning to stderr when env var values
fail to parse, e.g.: warning: invalid PGET_CONCURRENCY value abc, ignoring

Closes #123

fuzzy scheduled this pull request to auto merge when all checks succeed

2026-07-15 17:39:42 +00:00

the.auditor approved these changes

2026-07-15 17:40:29 +00:00

the.auditor left a comment

Review: APPROVED

Verification

go vet ./... — ✅ passes
go build ./... — ✅ passes
go test -race ./... — ✅ all pass

Change

internal/config/config.go — 7 else clauses added in applyEnvOverrides to print warning: invalid PGET_* value "...", ignoring on parse failure

Affects: PGET_CONCURRENCY, PGET_RETRIES, PGET_TIMEOUT, PGET_QUIET, PGET_VERBOSE, PGET_RESUME, PGET_RATE

Closes #123 on merge.

## Review: APPROVED ### Verification - `go vet ./...` — ✅ passes - `go build ./...` — ✅ passes - `go test -race ./...` — ✅ all pass ### Change - `internal/config/config.go` — 7 `else` clauses added in `applyEnvOverrides` to print `warning: invalid PGET_* value "...", ignoring` on parse failure Affects: PGET_CONCURRENCY, PGET_RETRIES, PGET_TIMEOUT, PGET_QUIET, PGET_VERBOSE, PGET_RESUME, PGET_RATE Closes #123 on merge.

fuzzy merged commit ace1051397 into main

2026-07-15 17:40:32 +00:00

fuzzy deleted branch feature/warn-invalid-env

2026-07-15 17:40:32 +00:00