thwap/pget
Watch
4
0
Fork
You've already forked pget
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

chore(deps): add core dependencies (konsoru, ftp) #120

Merged
fuzzy merged 2 commits from chore/add-core-dependencies into main 2026-07-13 17:18:31 +00:00
Conversation 1 Commits 2 Files changed 7 +30 -7
automation commented 2026-07-13 17:14:55 +00:00
Owner
Copy link

What

Add konsoru (progress bar) and ftp (FTP client) as module dependencies. Update CI Go version to 1.26 (required by ftp v0.2.1).

Why

Foundation for Phase 2+3 implementations: FTP downloads via github.com/jlaffaye/ftp, progress bars via git.lan.thwap.org/thwap/konsoru/bar.

Testing

  • go mod tidy resolves all imports cleanly
  • go vet ./... passes
  • go build ./... passes
  • golangci-lint run ./... passes
  • Pre-commit hooks pass

Breaking Changes

None

Notes

Go directive updated from 1.25.8 → 1.26 due to github.com/jlaffaye/ftp@v0.2.1 requirement.

Closes #0010
Closes #0011
Closes #0012
Closes #0013

## What Add konsoru (progress bar) and ftp (FTP client) as module dependencies. Update CI Go version to 1.26 (required by ftp v0.2.1). ## Why Foundation for Phase 2+3 implementations: FTP downloads via `github.com/jlaffaye/ftp`, progress bars via `git.lan.thwap.org/thwap/konsoru/bar`. ## Testing - [x] `go mod tidy` resolves all imports cleanly - [x] `go vet ./...` passes - [x] `go build ./...` passes - [x] `golangci-lint run ./...` passes - [x] Pre-commit hooks pass ## Breaking Changes None ## Notes Go directive updated from 1.25.8 → 1.26 due to `github.com/jlaffaye/ftp@v0.2.1` requirement. Closes #0010 Closes #0011 Closes #0012 Closes #0013
Closes #0010 Closes #0011 Closes #0012 Closes #0013
docs(roadmap): mark core dependencies complete
All checks were successful
Test and Release / test (pull_request) Successful in 1m50s
Details
Test and Release / lint (pull_request) Successful in 2m56s
Details
9a36e15370
fuzzy scheduled this pull request to auto merge when all checks succeed 2026-07-13 17:16:07 +00:00
the.auditor approved these changes 2026-07-13 17:18:29 +00:00
the.auditor left a comment
Copy link

Review: APPROVED

Verification

  • go vet ./... — ✅ passes
  • go build ./... — ✅ passes
  • go mod tidy — ✅ passes
  • golangci-lint v2.12.0 ./... — ✅ 0 issues

Changes

  • Added git.lan.thwap.org/thwap/konsoru v1.0.0 and github.com/jlaffaye/ftp v0.2.1
  • Updated Go directive 1.25.8 → 1.26
  • Updated CI workflows to Go 1.26
  • Added .gitignore for pget binary
  • Updated ROADMAP.md Phase 1 checkboxes

Suggestions (non-blocking)

  • #121 — Pre-existing bug in release.yml:35: ./cmd/9biff should be ./cmd/pget

Closes #0010, #0011, #0012, #0013 on merge.

## Review: APPROVED ### Verification - `go vet ./...` — ✅ passes - `go build ./...` — ✅ passes - `go mod tidy` — ✅ passes - `golangci-lint v2.12.0 ./...` — ✅ 0 issues ### Changes - Added `git.lan.thwap.org/thwap/konsoru v1.0.0` and `github.com/jlaffaye/ftp v0.2.1` - Updated Go directive `1.25.8` → `1.26` - Updated CI workflows to Go 1.26 - Added `.gitignore` for `pget` binary - Updated ROADMAP.md Phase 1 checkboxes ### Suggestions (non-blocking) - #121 — Pre-existing bug in `release.yml:35`: `./cmd/9biff` should be `./cmd/pget` Closes #0010, #0011, #0012, #0013 on merge.
fuzzy merged commit 9a36e15370 into main 2026-07-13 17:18:31 +00:00
fuzzy deleted branch chore/add-core-dependencies 2026-07-13 17:18:32 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
the.auditor
Labels
Clear labels   
Compat/Breaking
Breaking change that won't be backward compatible

  
Kind/Bug
Something is not working

  
Kind/Documentation
Documentation changes

  
Kind/Enhancement
Improve existing functionality

  
Kind/Feature
New functionality

  
Kind/Security
This is security issue

  
Kind/Testing
Issue or pull request related to testing

  
Priority
Critical
 The priority is critical

  
Priority
High
 The priority is high

  
Priority
Low
 The priority is low

  
Priority
Medium
 The priority is medium

  
Reviewed
Confirmed
 Issue has been confirmed

  
Reviewed
Duplicate
 This issue or pull request already exists

  
Reviewed
Invalid
 Invalid issue

  
Reviewed
Won't Fix
 This issue won't be fixed

  
Status
Abandoned
 Somebody has started to work on this but abandoned work

  
Status
Blocked
 Something is blocking this issue or pull request

  
Status
Need More Info
 Feedback is required to reproduce issue or to continue work

No labels
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
thwap/pget!120
No description provided.