feat(download): make retry count configurable via --retries flag #145
No reviewers
Labels
No labels
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
thwap/pget!145
Loading…
Reference in a new issue
No description provided.
Delete branch "feat/retry-backoff"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
What
Make retry count configurable via
--retries/-rflag andPGET_RETRIESenv var. Backoff already implemented as exponential (1s, 2s, 4s...).Why
Allows users to tune retry behavior. Default 3, min 0 (no retries).
Testing
go vet ./...passesgo build ./...passesgolangci-lint run ./...passesBreaking Changes
Download()signature changed — addedmaxRetries intparameter.Hardcoded
maxRetriesconstant removed — value now flows from config through download.Notes
Config.MaxRetriesadded,--retriesflag,PGET_RETRIESenv varrunWorkerreceivesmaxRetriesparameter instead of using package constantCloses #0056
Closes #0057
Closes #0058
Closes #0059
Review: APPROVED
Verification
go vet ./...— ✅ passesgo build ./...— ✅ passesgolangci-lint v2 run ./...— ✅ 0 issuesChanges
internal/config/config.go— addsMaxRetries,--retries/-rflag,PGET_RETRIESenv var, validationinternal/downloader/download.go— removes hardcodedmaxRetriesconstant, parameter flows from config throughDownload()torunWorker()ROADMAP.md— Marks Phase 2 retry items as [x]Closes #0056, #0057, #0058, #0059 on merge.