feat(config): add .pgetrc configuration file support #159
No reviewers
Labels
No labels
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
thwap/pget!159
Loading…
Reference in a new issue
No description provided.
Delete branch "feature/config-file"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
What
Add
~/.pgetrcconfiguration file support for setting default option values.Why
Users should be able to set persistent defaults (concurrency, rate limits, etc.) without passing CLI flags every time.
Implementation
loadConfigFile()reads$HOME/.pgetrcbefore CLI flag parsing, key=value format,#commentsconcurrency,retries,timeout,user-agent,rate,output,resume,quiet,verbose,checksum,headerConfig file: ~/.pgetrcTesting
~/.pgetrcwithconcurrency=5sets default before CLI parsing-n 3overrides config fileconcurrency=5PGET_CONCURRENCY=10overrides everything.pgetrcfile — no error, uses built-in defaultsgo build ./...,go vet ./...,golangci-lint run— all cleanBreaking Changes
None
Closes #103, #101, #102
Review: APPROVED
Verification
go vet ./...— ✅ passesgo build ./...— ✅ passesgolangci-lint v2 run ./...— ✅ 0 issuesChanges
internal/config/config.go—loadConfigFile()reads~/.pgetrc(key=value, # comments) before CLI parsing; silent if file missing/unreadable; 11 supported keys covering all config fieldsPriority (lowest to highest)
~/.pgetrcconfig filePGET_*)Supported keys
concurrency,retries,timeout,user-agent,rate,output,resume,quiet,verbose,checksum,headerCloses #101, #102, #103 on merge.