thwap/steeper
Watch
4
0
Fork
You've already forked steeper
 0
Code Issues 2 Pull requests Projects Releases Packages Wiki Activity Actions

docs(activity): clarify Date field uses UTC timezone #338

Merged
fuzzy merged 1 commit from docs/287-date-timezone-semantics into main 2026-07-08 05:02:41 +00:00
Conversation 1 Commits 1 Files changed 1 +1 -1
automation commented 2026-07-08 05:01:57 +00:00
Owner
Copy link

What

Update DailyActivity.Date field comment from YYYY-MM-DD to UTC date in YYYY-MM-DD format.

Why

The timezone was unspecified, creating ambiguity for cache invalidation and cross-timezone display. The field is populated from f.Created.UTC() in AggregateActivityByDay, so it is always UTC. This should be explicit.

Testing

  • go build passes
  • go test -race -short ./... passes
  • golangci-lint passes

Closes #287

## What Update `DailyActivity.Date` field comment from `YYYY-MM-DD` to `UTC date in YYYY-MM-DD format`. ## Why The timezone was unspecified, creating ambiguity for cache invalidation and cross-timezone display. The field is populated from `f.Created.UTC()` in `AggregateActivityByDay`, so it is always UTC. This should be explicit. ## Testing - [x] `go build` passes - [x] `go test -race -short ./...` passes - [x] golangci-lint passes Closes #287
docs(activity): clarify Date field uses UTC timezone
All checks were successful
Test and Release / lint (pull_request) Successful in 27s
Details
Test and Release / test (pull_request) Successful in 40s
Details
16bf63e355 
Update DailyActivity.Date comment from 'YYYY-MM-DD' to 'UTC date
in YYYY-MM-DD format' to disambiguate timezone semantics for
cache invalidation and cross-timezone display.
fuzzy scheduled this pull request to auto merge when all checks succeed 2026-07-08 05:02:07 +00:00
the.auditor approved these changes 2026-07-08 05:02:26 +00:00
the.auditor left a comment
Copy link

Review

Result: Approved — no issues. Closes #287.

One-line doc fix: // YYYY-MM-DD → // UTC date in YYYY-MM-DD format. Removes timezone ambiguity.

## Review **Result: Approved** — no issues. Closes #287. One-line doc fix: `// YYYY-MM-DD` → `// UTC date in YYYY-MM-DD format`. Removes timezone ambiguity.
fuzzy merged commit 16bf63e355 into main 2026-07-08 05:02:41 +00:00
fuzzy deleted branch docs/287-date-timezone-semantics 2026-07-08 05:02:41 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
the.auditor
Labels
Clear labels   
Compat/Breaking
Breaking change that won't be backward compatible

  
Kind/Bug
Something is not working

  
Kind/Documentation
Documentation changes

  
Kind/Enhancement
Improve existing functionality

  
Kind/Feature
New functionality

  
Kind/Security
This is security issue

  
Kind/Testing
Issue or pull request related to testing

  
Priority
Critical
 The priority is critical

  
Priority
High
 The priority is high

  
Priority
Low
 The priority is low

  
Priority
Medium
 The priority is medium

  
Reviewed
Confirmed
 Issue has been confirmed

  
Reviewed
Duplicate
 This issue or pull request already exists

  
Reviewed
Invalid
 Invalid issue

  
Reviewed
Won't Fix
 This issue won't be fixed

  
Status
Abandoned
 Somebody has started to work on this but abandoned work

  
Status
Blocked
 Something is blocking this issue or pull request

  
Status
Need More Info
 Feedback is required to reproduce issue or to continue work

No labels
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
thwap/steeper!338
No description provided.