thwap/steeper
Watch
4
0
Fork
You've already forked steeper
 0
Code Issues 2 Pull requests Projects Releases Packages Wiki Activity Actions

docs(activity): document fetched_at format and Cache concurrency safety #340

Merged
fuzzy merged 1 commit from docs/290-cache-fetched-at-docs into main 2026-07-08 07:50:32 +00:00
Conversation 1 Commits 1 Files changed 1 +4 -1
automation commented 2026-07-08 07:49:52 +00:00
Owner
Copy link

What

  • Add SQL comment on fetched_at column specifying RFC3339 format
  • Add godoc on Cache struct documenting that sql.DB is safe for concurrent use

Why

The fetched_at format was unspecified, making it unclear how to parse or compare timestamps. The Cache struct lacked any doc comment about concurrency despite being shared across goroutines.

Testing

  • go build passes
  • go test -race -short ./... passes
  • golangci-lint passes

Closes #290

## What - Add SQL comment on `fetched_at` column specifying RFC3339 format - Add godoc on `Cache` struct documenting that `sql.DB` is safe for concurrent use ## Why The `fetched_at` format was unspecified, making it unclear how to parse or compare timestamps. The `Cache` struct lacked any doc comment about concurrency despite being shared across goroutines. ## Testing - [x] `go build` passes - [x] `go test -race -short ./...` passes - [x] golangci-lint passes Closes #290
docs(activity): document fetched_at format and Cache concurrency safety
All checks were successful
Test and Release / test (pull_request) Successful in 28s
Details
Test and Release / lint (pull_request) Successful in 28s
Details
0ebd476e5c 
- Add SQL comment specifying fetched_at uses RFC3339 format
- Add godoc on Cache struct documenting sql.DB concurrency safety
fuzzy scheduled this pull request to auto merge when all checks succeed 2026-07-08 07:50:30 +00:00
the.auditor approved these changes 2026-07-08 07:50:31 +00:00
the.auditor left a comment
Copy link

Review

Result: Approved — no issues. Closes #290.

5-line doc change: Cache struct godoc noting sql.DB concurrency safety, and -- RFC3339 SQL comment on fetched_at column. No functional change.

## Review **Result: Approved** — no issues. Closes #290. 5-line doc change: `Cache` struct godoc noting `sql.DB` concurrency safety, and `-- RFC3339` SQL comment on `fetched_at` column. No functional change.
fuzzy merged commit 0ebd476e5c into main 2026-07-08 07:50:32 +00:00
fuzzy deleted branch docs/290-cache-fetched-at-docs 2026-07-08 07:50:32 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
the.auditor
Labels
Clear labels   
Compat/Breaking
Breaking change that won't be backward compatible

  
Kind/Bug
Something is not working

  
Kind/Documentation
Documentation changes

  
Kind/Enhancement
Improve existing functionality

  
Kind/Feature
New functionality

  
Kind/Security
This is security issue

  
Kind/Testing
Issue or pull request related to testing

  
Priority
Critical
 The priority is critical

  
Priority
High
 The priority is high

  
Priority
Low
 The priority is low

  
Priority
Medium
 The priority is medium

  
Reviewed
Confirmed
 Issue has been confirmed

  
Reviewed
Duplicate
 This issue or pull request already exists

  
Reviewed
Invalid
 Invalid issue

  
Reviewed
Won't Fix
 This issue won't be fixed

  
Status
Abandoned
 Somebody has started to work on this but abandoned work

  
Status
Blocked
 Something is blocking this issue or pull request

  
Status
Need More Info
 Feedback is required to reproduce issue or to continue work

No labels
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
thwap/steeper!340
No description provided.