feat(explore): add search input box to explore tab views #361

Merged

fuzzy merged 14 commits from feat/352-explore-search into main 2026-07-08 09:52:51 +00:00

Conversation 2 Commits 14 Files changed 2 +270 -69

automation commented 2026-07-08 09:12:33 +00:00

Owner

Copy link

What

Add search InputField to Explore tab. / focuses search, typing filters client-side, Enter triggers API search, Escape clears.

Closes #352

## What Add search InputField to Explore tab. `/` focuses search, typing filters client-side, Enter triggers API search, Escape clears. Closes #352

automation added 1 commit 2026-07-08 09:12:34 +00:00

feat(explore): add search input box to explore tab views ... ed9daea541

- Search input field with / keybinding to focus
- Client-side filtering on text change for all views
- Enter triggers API search for users and repos
- Escape clears search and resets to full list
- No results / empty state handling per view

the.auditor referenced this pull request 2026-07-08 09:13:14 +00:00

refactor(explore): remove dead SearchInputChanged/SearchInputDone methods #362

the.auditor approved these changes 2026-07-08 09:13:21 +00:00

Dismissed

the.auditor left a comment

Copy link

Review

Result: Approved — no blocking issues.

Summary: Adds search to Explore tab. / focuses input field, typing filters client-side via substring match on both columns, Enter triggers API-backed search (users/repos only). Escape clears search text. Search resets on sub-view switch. Keybar updated.

Non-blocking:

• #362 — Dead code: SearchInputChanged/SearchInputDone are exported but unused (callbacks set directly in constructor)

Checklist:

• Correctness: ✅ Client-side filter case-insensitive, API search works for users+repos, sub-view switch resets search
• Completeness: ✅ Covers all 3 sub-views with client-side filtering, API search for users+repos
• Error handling: ✅ API errors shown in title bar, empty results show contextual "No X matching 'query'" message
• Build: ✅ Passes clean

## Review **Result: Approved** — no blocking issues. **Summary:** Adds search to Explore tab. `/` focuses input field, typing filters client-side via substring match on both columns, Enter triggers API-backed search (users/repos only). Escape clears search text. Search resets on sub-view switch. Keybar updated. **Non-blocking:** - #362 — Dead code: `SearchInputChanged`/`SearchInputDone` are exported but unused (callbacks set directly in constructor) **Checklist:** - Correctness: ✅ Client-side filter case-insensitive, API search works for users+repos, sub-view switch resets search - Completeness: ✅ Covers all 3 sub-views with client-side filtering, API search for users+repos - Error handling: ✅ API errors shown in title bar, empty results show contextual "No X matching 'query'" message - Build: ✅ Passes clean

fuzzy self-assigned this 2026-07-08 09:14:18 +00:00

fuzzy added 1 commit 2026-07-08 09:14:32 +00:00

style(explore): add horizontal bars above and below search input 3dd70d1610

fuzzy dismissed the.auditor's review 2026-07-08 09:14:32 +00:00

Reason:

New commits pushed, approval review dismissed automatically according to repository settings

fuzzy added 1 commit 2026-07-08 09:17:17 +00:00

feat(explore): add pagination with n key to load more results 361e337957

fuzzy added 1 commit 2026-07-08 09:18:09 +00:00

style(explore): add 1-column horizontal padding around results table 0282cc8d26

fuzzy added 1 commit 2026-07-08 09:20:34 +00:00

fix(explore): force redraw after loading more results 2b364c5e2c

fuzzy added 1 commit 2026-07-08 09:25:35 +00:00

fix(explore): fetch all pages on load, remove n keybinding ... d9c099839b

Load all available results (up to 500, 10 pages of 50) on tab open.
No manual pagination required.

fuzzy added 1 commit 2026-07-08 09:27:44 +00:00

fix(explore): remove real-time client-side filter, only search on Enter ... 0fb5848316

Rebuilding 500+ table rows on every keystroke locks the event loop.
Search now triggers via Enter (API call), not on text change.

fuzzy added 1 commit 2026-07-08 09:29:45 +00:00

fix(tui): pass Backspace/Escape through to focused primitive on main tabs ... ed9168f3f6

The global handler unconditionally returned nil for Backspace/Escape/DEL,
consuming the key even on main tab pages where InputFields need them.
Now only consumes when the help modal is open or navigating back.

fuzzy added 1 commit 2026-07-08 09:30:21 +00:00

fix(tui): pass Backspace/DEL through to focused primitive on main tabs ... e88ffd19ad

Keep Escape behavior unchanged (always consumed). Only Backspace
and DEL pass through to InputField when on main tab pages.

fuzzy added 1 commit 2026-07-08 09:33:22 +00:00

fix(explore): fetch results in background goroutine, not on main thread ... 8236d9b488

Sequential API calls block the tview event loop, freezing the UI
including Ctrl+C. Fetch in goroutine, render via QueueUpdateDraw.

fuzzy added 1 commit 2026-07-08 09:39:25 +00:00

fix(explore): use separate Box primitives for table padding 6a86a8d3c0

fuzzy added 1 commit 2026-07-08 09:43:20 +00:00

fix(explore): run searchAPI in goroutine, render via QueueUpdateDraw 86e3c74590

fuzzy added 1 commit 2026-07-08 09:46:18 +00:00

fix(explore): escape blurs search input to table, skip refresh on active search ... 1b448154a9

- Escape with search focused: clear, blur, focus table
- Auto-refresh and Ctrl+R skip reload when search is active

fuzzy added 1 commit 2026-07-08 09:49:53 +00:00

feat(explore): Tab moves focus from search input to table fd50c3c715

the.auditor referenced this pull request 2026-07-08 09:51:42 +00:00

feat(explore): restore live client-side filtering on search input #363

the.auditor approved these changes 2026-07-08 09:51:49 +00:00

the.auditor left a comment

Copy link

Re-Review

Result: Approved — no blocking issues. Significant restructuring from previous version.

Changes since previous review:

• Async loading with goroutines and full pagination (up to 10 pages × 50 items)
• Loading indicator ("Loading...") shown in title during fetch
• Tab key toggles focus between search input and table
• Escape logic split from Backspace in global handler — Escape clears search, Backspace navigates back
• Auto-refresh/Ctrl+R skips reload when search input has text (preserves results)
• Separators around search input
• loaded field removed (async doesn't need it)
• SearchInputChanged/SearchInputDone dead code removed

Non-blocking:

• #362 — Already filed (resolved by this update)
• #363 — SetChangedFunc removed — typing no longer filters in real-time. Filter functions exist but only run on data load or API search

Checklist:

• Correctness: ✅ Pagination, async loading, concurrency-safe via QueueUpdateDraw
• Completeness: ✅ Search, filter, pagination, sub-view switching all functional
• Concurrency: ✅ All UI updates via QueueUpdateDraw, goroutine-safe

## Re-Review **Result: Approved** — no blocking issues. Significant restructuring from previous version. **Changes since previous review:** - Async loading with goroutines and full pagination (up to 10 pages × 50 items) - Loading indicator ("Loading...") shown in title during fetch - Tab key toggles focus between search input and table - Escape logic split from Backspace in global handler — Escape clears search, Backspace navigates back - Auto-refresh/Ctrl+R skips reload when search input has text (preserves results) - Separators around search input - `loaded` field removed (async doesn't need it) - `SearchInputChanged`/`SearchInputDone` dead code removed **Non-blocking:** - #362 — Already filed (resolved by this update) - #363 — `SetChangedFunc` removed — typing no longer filters in real-time. Filter functions exist but only run on data load or API search **Checklist:** - Correctness: ✅ Pagination, async loading, concurrency-safe via QueueUpdateDraw - Completeness: ✅ Search, filter, pagination, sub-view switching all functional - Concurrency: ✅ All UI updates via QueueUpdateDraw, goroutine-safe

fuzzy scheduled this pull request to auto merge when all checks succeed 2026-07-08 09:52:09 +00:00

fuzzy merged commit fd50c3c715 into main 2026-07-08 09:52:51 +00:00

fuzzy deleted branch feat/352-explore-search 2026-07-08 09:52:52 +00:00

Sign in to join this conversation.

Reviewers

No reviewers

the.auditor

Labels

Clear labels   

Compat/Breaking

Breaking change that won't be backward compatible

  

Kind/Bug

Something is not working

  

Kind/Documentation

Documentation changes

  

Kind/Enhancement

Improve existing functionality

  

Kind/Feature

New functionality

  

Kind/Security

This is security issue

  

Kind/Testing

Issue or pull request related to testing

  

Priority

Critical

The priority is critical

  

Priority

High

The priority is high

  

Priority

Low

The priority is low

  

Priority

Medium

The priority is medium

  

Reviewed

Confirmed

Issue has been confirmed

  

Reviewed

Duplicate

This issue or pull request already exists

  

Reviewed

Invalid

Invalid issue

  

Reviewed

Won't Fix

This issue won't be fixed

  

Status

Abandoned

Somebody has started to work on this but abandoned work

  

Status

Blocked

Something is blocking this issue or pull request

  

Status

Need More Info

Feedback is required to reproduce issue or to continue work

No labels

Compat/Breaking

Kind/Bug

Kind/Documentation

Kind/Enhancement

Kind/Feature

Kind/Security

Kind/Testing

Priority

Critical

Priority

High

Priority

Low

Priority

Medium

Reviewed

Confirmed

Reviewed

Duplicate

Reviewed

Invalid

Reviewed

Won't Fix

Status

Abandoned

Status

Blocked

Status

Need More Info

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

fuzzy

3 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

thwap/steeper!361

No description provided.