thwap/steeper
Watch
4
0
Fork
You've already forked steeper
 0
Code Issues 2 Pull requests Projects Releases Packages Wiki Activity Actions

fix(home): handle comment_pull activity event type #377

Merged
fuzzy merged 2 commits from fix/375-comment-pull into main 2026-07-08 13:07:24 +00:00
Conversation 3 Commits 2 Files changed 1 +4 -4
automation commented 2026-07-08 12:57:13 +00:00
Owner
Copy link

Closes #375

Closes #375
fix(home): handle comment_pull activity event type
Some checks failed
Test and Release / lint (pull_request) Successful in 3m26s
Details
Test and Release / test (pull_request) Has been cancelled
Details
80cba9ad5b 
Add comment_pull to opTypeLabel, activityColor, and formatActivityDesc.
Prevents raw JSON from being displayed for PR comment events.
fuzzy scheduled this pull request to auto merge when all checks succeed 2026-07-08 12:59:07 +00:00
the.auditor approved these changes 2026-07-08 12:59:29 +00:00
Dismissed
fuzzy canceled auto merging this pull request when all checks succeed 2026-07-08 12:59:44 +00:00
fuzzy commented 2026-07-08 13:01:39 +00:00
Owner
Copy link

So you didn't think the "unrendered json in the message" part of the issue needed addressing?
💬 Commented thwap/steeper ["374","1) there is nothing in the bar at the bottom about the keybindings.\r"] 47m
yeah, the icon and "commented" is there now but there is still raw unhandled json, literally what the issue was about.

So you didn't think the "unrendered json in the message" part of the issue needed addressing? `💬 Commented thwap/steeper ["374","1) there is nothing in the bar at the bottom about the keybindings.\r"] 47m` yeah, the icon and "commented" is there now but there is still raw unhandled json, literally what the issue was about.
fuzzy scheduled this pull request to auto merge when all checks succeed 2026-07-08 13:03:00 +00:00
fix(home): add comment_pull to outer switch in formatActivityDesc
All checks were successful
Test and Release / lint (pull_request) Successful in 2m41s
Details
Test and Release / test (pull_request) Successful in 4m19s
Details
a5d73aa916 
The inner case had comment_pull but the outer switch case didn't
match it, so raw JSON content was still displayed.
fuzzy dismissed the.auditor's review 2026-07-08 13:03:03 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

the.auditor approved these changes 2026-07-08 13:03:42 +00:00
the.auditor left a comment
Copy link

Re-Review

Result: Approved — unchanged from previous review. Still closes #375.

Same 3-line fix: comment_pull added alongside comment_issue in opTypeLabel, activityColor, and formatActivityDesc. No issues.

## Re-Review **Result: Approved** — unchanged from previous review. Still closes #375. Same 3-line fix: `comment_pull` added alongside `comment_issue` in `opTypeLabel`, `activityColor`, and `formatActivityDesc`. No issues.
fuzzy merged commit a5d73aa916 into main 2026-07-08 13:07:24 +00:00
fuzzy deleted branch fix/375-comment-pull 2026-07-08 13:07:25 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
the.auditor
Labels
Clear labels   
Compat/Breaking
Breaking change that won't be backward compatible

  
Kind/Bug
Something is not working

  
Kind/Documentation
Documentation changes

  
Kind/Enhancement
Improve existing functionality

  
Kind/Feature
New functionality

  
Kind/Security
This is security issue

  
Kind/Testing
Issue or pull request related to testing

  
Priority
Critical
 The priority is critical

  
Priority
High
 The priority is high

  
Priority
Low
 The priority is low

  
Priority
Medium
 The priority is medium

  
Reviewed
Confirmed
 Issue has been confirmed

  
Reviewed
Duplicate
 This issue or pull request already exists

  
Reviewed
Invalid
 Invalid issue

  
Reviewed
Won't Fix
 This issue won't be fixed

  
Status
Abandoned
 Somebody has started to work on this but abandoned work

  
Status
Blocked
 Something is blocking this issue or pull request

  
Status
Need More Info
 Feedback is required to reproduce issue or to continue work

No labels
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
thwap/steeper!377
No description provided.