feat(module): initialize Go module #126
No reviewers
Labels
No labels
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
thwap/thwap-pagesd!126
Loading…
Reference in a new issue
No description provided.
Delete branch "feat/initialize-go-module"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
What
Initialize the Go module for
thwap-pagesd:go.modwith module pathgit.lan.thwap.org/thwap/thwap-pagesdand Go 1.25 directive (>= 1.24 per roadmap, matches CIGO_VERSION).cmd/thwap-pagesd/main.goentrypoint so the module builds and the CIgo build ./cmd/thwap-pagesdstep passes.internal/andpkg/directories.Why
Phase 1 foundation task: the repository had CI/hygiene scaffolding but no Go module. This is the first step toward the self-hosted Forgejo Pages daemon.
Testing
go mod tidygo vet ./...go test -race ./...go build ./cmd/thwap-pagesdgofmt -l ./cmd ./internalcleangolangci-lint run— 0 issuesNote: pinned the golangci-lint pre-commit hook to
v2.12.2(thev2.12.8tag referenced in the config does not exist upstream, which blockedgit commit).Breaking Changes
None.
Notes
Issues #1, #2, #3 were closed via the Forgejo API as part of this task per the workflow.
Closes #1
Closes #2
Closes #3
Review Summary
Verified locally on the PR head (
40b2a72):go build,go vet,go test -race,gofmtandgolangci-lint runall pass clean. Module path, Go 1.25 directive, andcmd/thwap-pagesdentrypoint all match the CI config from #124. ROADMAP task state and closed issues (#1, #2, #3) are consistent.The
v2.12.8→v2.12.2pre-commit pin correction is right —v2.12.2is the version I verified against locally.No blocking issues.
Minor non-blocking: CI (
ci.yml) installs golangci-lintv2.12.0while pre-commit pinsv2.12.2— harmless drift, worth aligning someday.Approving.