thwap/ttheart

Watch

Fork 0

feat(logging): implement leveled logger with timestamp prefixes #176

Merged

fuzzy merged 2 commits from feature/implement-logging into main

2026-07-06 07:24:11 +00:00

automation commented

2026-07-06 07:21:34 +00:00

Owner

What

Implement a leveled logger in logging/logger.go wrapping the standard log package:

Info() — informational messages with [INFO] prefix and timestamp
Warn() — warning messages with [WARN] prefix and timestamp
Error() — error messages with [ERROR] prefix and timestamp
New() — default constructor writing to os.Stdout
NewFromWriter() — configurable writer for testing and custom output

Why

Centralized logging is required by the project conventions. All components (webhook handler, rule matcher, executor) will use this logger for consistent, leveled output.

Testing

Unit tests pass — 3 subtests verifying each log level outputs correct prefix and routed message
Integration tests pass — N/A
Manual testing performed — go test ./... and pre-commit pass
New tests added for new functionality — logger_test.go with table-driven tests

Breaking Changes

None.

Notes

Uses log.LstdFlags for date/time prefix on every line
External test package (package logging_test) for public API testing
Location follows Go conventions: top-level logging/ directory

Closes #25
Closes #22
Closes #23
Closes #24

## What Implement a leveled logger in `logging/logger.go` wrapping the standard `log` package: - `Info()` — informational messages with `[INFO]` prefix and timestamp - `Warn()` — warning messages with `[WARN]` prefix and timestamp - `Error()` — error messages with `[ERROR]` prefix and timestamp - `New()` — default constructor writing to `os.Stdout` - `NewFromWriter()` — configurable writer for testing and custom output ## Why Centralized logging is required by the project conventions. All components (webhook handler, rule matcher, executor) will use this logger for consistent, leveled output. ## Testing - [x] Unit tests pass — 3 subtests verifying each log level outputs correct prefix and routed message - [ ] Integration tests pass — N/A - [x] Manual testing performed — `go test ./...` and pre-commit pass - [x] New tests added for new functionality — `logger_test.go` with table-driven tests ## Breaking Changes None. ## Notes - Uses `log.LstdFlags` for date/time prefix on every line - External test package (`package logging_test`) for public API testing - Location follows Go conventions: top-level `logging/` directory Closes #25 Closes #22 Closes #23 Closes #24

automation added 2 commits

2026-07-06 07:21:34 +00:00

feat(logging): implement leveled logger with timestamp prefixes 61f4af0abf

Add Logger wrapping standard log package with Info, Warn, Error levels.
Each level prepends [INFO], [WARN], or [ERROR] prefix with timestamp.
Logger writes to os.Stdout by default or any configurable writer.

Closes #22
Closes #23
Closes #24

docs: mark Implement logging infrastructure tasks as complete

CI / Lint (golangci-lint) (pull_request) Successful in 1m8s

Details

CI / Pre-commit Hooks (pull_request) Successful in 1m59s

Details

CI / Test (pull_request) Successful in 1m18s

Details

CI / Lint (golangci-lint) (push) Successful in 1m17s

Details

CI / Pre-commit Hooks (push) Successful in 2m9s

Details

CI / Test (push) Successful in 1m26s

Details

5414abfd71

Closes #25

fuzzy scheduled this pull request to auto merge when all checks succeed

2026-07-06 07:22:24 +00:00

the.auditor referenced this pull request

2026-07-06 07:23:06 +00:00

logger: NewFromWriter should accept io.Writer instead of *os.File #177

the.auditor approved these changes

2026-07-06 07:23:11 +00:00

the.auditor left a comment

Review

Clean implementation of a leveled logger. Lint, vet, and tests all pass with zero issues.

Design: Logger wraps log.New with separate instances per level. Prefix spacing aligns output nicely:

[INFO]  message
[WARN]  message
[ERROR] message

Uses log.LstdFlags for timestamp prefixes. New() writes to os.Stdout, NewFromWriter() allows writer injection.

Tests: Table-driven, covers all three levels, verifies both prefix and formatted message via pipe capture. External test package — proper for public API testing.

Non-blocking

logger.go:26 — NewFromWriter accepts *os.File but should accept io.Writer for flexibility. Filed as #177.

No blocking issues.

APPROVED

## Review Clean implementation of a leveled logger. Lint, vet, and tests all pass with zero issues. **Design**: Logger wraps `log.New` with separate instances per level. Prefix spacing aligns output nicely: ``` [INFO] message [WARN] message [ERROR] message ``` Uses `log.LstdFlags` for timestamp prefixes. `New()` writes to `os.Stdout`, `NewFromWriter()` allows writer injection. **Tests**: Table-driven, covers all three levels, verifies both prefix and formatted message via pipe capture. External test package — proper for public API testing. ## Non-blocking 1. `logger.go:26` — `NewFromWriter` accepts `*os.File` but should accept `io.Writer` for flexibility. Filed as #177. **No blocking issues.** **APPROVED**

fuzzy merged commit 5414abfd71 into main

2026-07-06 07:24:11 +00:00

fuzzy deleted branch feature/implement-logging

2026-07-06 07:24:11 +00:00