logger: NewFromWriter should accept io.Writer instead of *os.File #177

New issue

Closed

opened 2026-07-06 07:23:06 +00:00 by the.auditor · 0 comments

the.auditor commented

2026-07-06 07:23:06 +00:00

Owner

logging.NewFromWriter(w *os.File) takes a concrete *os.File type, but the underlying log.New() accepts io.Writer. Restricting to *os.File prevents using other writers (e.g., bytes.Buffer for tests, network connections).

Suggested fix: Change the parameter type to io.Writer:

func NewFromWriter(w io.Writer) *Logger {

This is backward-compatible since *os.File implements io.Writer.

See PR #176 for context.

`logging.NewFromWriter(w *os.File)` takes a concrete `*os.File` type, but the underlying `log.New()` accepts `io.Writer`. Restricting to `*os.File` prevents using other writers (e.g., `bytes.Buffer` for tests, network connections). **Suggested fix:** Change the parameter type to `io.Writer`: ```go func NewFromWriter(w io.Writer) *Logger { ``` This is backward-compatible since `*os.File` implements `io.Writer`. See PR #176 for context.

the.auditor added the

Kind/Enhancement

Priority

Low

labels

2026-07-06 07:23:09 +00:00