thwap/kronai
Watch
4
0
Fork
You've already forked kronai
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

refactor(llm): replace retryable monkey-patch with RetryableLLMError subclass #129

Merged
fuzzy merged 1 commit from fix/0085-retryable-llm-error-subclass into main 2026-07-05 16:30:07 +00:00
Conversation 1 Commits 1 Files changed 2 +7 -13
automation commented 2026-07-05 16:25:20 +00:00
Owner
Copy link

What

Replace the _retryable monkey-patch (object.__setattr__) with a proper RetryableLLMError(LLMError) subclass for a cleaner, more idiomatic design.

Why

Monkey-patching exception instances with object.__setattr__ is fragile and non-standard.

Testing

  • 145 unit tests pass
  • Pre-commit hooks pass

Closes #85

## What Replace the `_retryable` monkey-patch (`object.__setattr__`) with a proper `RetryableLLMError(LLMError)` subclass for a cleaner, more idiomatic design. ## Why Monkey-patching exception instances with `object.__setattr__` is fragile and non-standard. ## Testing - [x] 145 unit tests pass - [x] Pre-commit hooks pass Closes #85
refactor(llm): replace retryable monkey-patch with RetryableLLMError subclass
All checks were successful
CI / test (pull_request) Successful in 51s
Details
CI / lint (pull_request) Successful in 1m23s
Details
a46cfb3532 
Cleaner, more idiomatic design using proper exception subclass
instead of object.__setattr__ on LLMError instances.
Closes #85
fuzzy force-pushed fix/0085-retryable-llm-error-subclass from a46cfb3532
All checks were successful
CI / test (pull_request) Successful in 51s
Details
CI / lint (pull_request) Successful in 1m23s
Details
to a0b1315996
All checks were successful
CI / lint (pull_request) Successful in 1m23s
Details
CI / test (pull_request) Successful in 50s
Details
2026-07-05 16:27:08 +00:00 Compare
the.auditor approved these changes 2026-07-05 16:29:44 +00:00
the.auditor left a comment
Copy link

Automated Review — PR #129

Result: APPROVED

Clean refactor. Replaces object.__setattr__ monkey-patch with proper RetryableLLMError(LLMError) subclass. Removes 15 lines of fragile code, replaces with 5 lines of clean class definition. Also adds py.typed marker for PEP 561 compliance. Closes #85.

No suggestions.

## Automated Review — PR #129 **Result: APPROVED** --- Clean refactor. Replaces `object.__setattr__` monkey-patch with proper `RetryableLLMError(LLMError)` subclass. Removes 15 lines of fragile code, replaces with 5 lines of clean class definition. Also adds `py.typed` marker for PEP 561 compliance. Closes #85. No suggestions.
fuzzy merged commit a0b1315996 into main 2026-07-05 16:30:07 +00:00
fuzzy deleted branch fix/0085-retryable-llm-error-subclass 2026-07-05 16:30:07 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
the.auditor
Labels
Clear labels   
Compat/Breaking
Breaking change that won't be backward compatible

  
Kind/Bug
Something is not working

  
Kind/Documentation
Documentation changes

  
Kind/Enhancement
Improve existing functionality

  
Kind/Feature
New functionality

  
Kind/Security
This is security issue

  
Kind/Testing
Issue or pull request related to testing

  
Priority
Critical
 The priority is critical

  
Priority
High
 The priority is high

  
Priority
Low
 The priority is low

  
Priority
Medium
 The priority is medium

  
Reviewed
Confirmed
 Issue has been confirmed

  
Reviewed
Duplicate
 This issue or pull request already exists

  
Reviewed
Invalid
 Invalid issue

  
Reviewed
Won't Fix
 This issue won't be fixed

  
Status
Abandoned
 Somebody has started to work on this but abandoned work

  
Status
Blocked
 Something is blocking this issue or pull request

  
Status
Need More Info
 Feedback is required to reproduce issue or to continue work

No labels
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
thwap/kronai!129
No description provided.