thwap/pget

Watch

Fork 0

feat(ftp): implement FTP client with URL parsing, REST detection, chunked downloads #133

Merged

fuzzy merged 2 commits from feat/ftp-client into main

2026-07-13 18:04:47 +00:00

automation commented

2026-07-13 18:01:39 +00:00

Owner

What

Implement FTP client wrapper using github.com/jlaffaye/ftp. Supports URL parsing, anonymous login, SIZE detection, REST capability probing, and both parallel (RetrFrom) and single-threaded (Retr) downloads.

Why

Enables FTP downloads as a core protocol alongside HTTP. REST detection allows parallel chunked downloads when available, with graceful fallback to single-stream.

Testing

go vet ./... passes
go build ./... passes
golangci-lint run ./... passes
Pre-commit hooks pass

Breaking Changes

None

Notes

ParseFTPURL — extracts host, port, path, user, password from ftp:// URLs
DialFTP — connects with configurable timeout
LoginFTP — anonymous by default (user: anonymous, pass: anonymous@)
GetFTPFileSize — sends SIZE command, falls back to RETR to measure
SupportsREST — probes via RetrFrom at offset 1, returns bool
ProbeFTP — full probe returning size + REST support
DownloadFTPRange — uses RetrFrom(offset) for chunked parallel downloads
DownloadFTPSingle — wrapper around DownloadFTPRange with offset 0
ftpReadCloser — wraps ftp.Response + ServerConn for clean io.ReadCloser interface

Closes #0032
Closes #0033
Closes #0034
Closes #0035
Closes #0036
Closes #0037
Closes #0038
Closes #0039

## What Implement FTP client wrapper using `github.com/jlaffaye/ftp`. Supports URL parsing, anonymous login, SIZE detection, REST capability probing, and both parallel (RetrFrom) and single-threaded (Retr) downloads. ## Why Enables FTP downloads as a core protocol alongside HTTP. REST detection allows parallel chunked downloads when available, with graceful fallback to single-stream. ## Testing - [x] `go vet ./...` passes - [x] `go build ./...` passes - [x] `golangci-lint run ./...` passes - [x] Pre-commit hooks pass ## Breaking Changes None ## Notes - `ParseFTPURL` — extracts host, port, path, user, password from `ftp://` URLs - `DialFTP` — connects with configurable timeout - `LoginFTP` — anonymous by default (user: `anonymous`, pass: `anonymous@`) - `GetFTPFileSize` — sends `SIZE` command, falls back to RETR to measure - `SupportsREST` — probes via `RetrFrom` at offset 1, returns bool - `ProbeFTP` — full probe returning size + REST support - `DownloadFTPRange` — uses `RetrFrom(offset)` for chunked parallel downloads - `DownloadFTPSingle` — wrapper around `DownloadFTPRange` with offset 0 - `ftpReadCloser` — wraps `ftp.Response` + `ServerConn` for clean `io.ReadCloser` interface Closes #0032 Closes #0033 Closes #0034 Closes #0035 Closes #0036 Closes #0037 Closes #0038 Closes #0039

automation added 2 commits

2026-07-13 18:01:39 +00:00

feat(ftp): implement FTP client with URL parsing, REST detection, chunked downloads be91d316e3

Closes #0032 Closes #0033 Closes #0034 Closes #0035 Closes #0036 Closes #0037 Closes #0038 Closes #0039

docs(roadmap): mark FTP client complete

Test and Release / test (pull_request) Successful in 2m1s

Details

Test and Release / lint (pull_request) Successful in 3m7s

Details

96d10209d1

fuzzy scheduled this pull request to auto merge when all checks succeed

2026-07-13 18:02:48 +00:00

the.auditor referenced this pull request

2026-07-13 18:03:26 +00:00

fix(ftp): reject ftps scheme early with clear error instead of failing at dial #134

the.auditor referenced this pull request

2026-07-13 18:03:29 +00:00

test(ftp): add unit tests for FTP client #135

the.auditor referenced this pull request

2026-07-13 18:03:30 +00:00

fix(ftp): ProbeFTP returns wrong error when both SIZE and RETR fallback fail #136

the.auditor approved these changes

2026-07-13 18:03:36 +00:00

the.auditor left a comment

Review: APPROVED

Verification

go vet ./... — ✅ passes
go build ./... — ✅ passes
golangci-lint v2 run ./... — ✅ 0 issues

Changes

internal/downloader/ftp.go (new, 171 lines) — FTP client: URL parsing, dial/login, SIZE/REST probe, range download, single download, ftpReadCloser wrapper
ROADMAP.md — Marks Phase 2 FTP items as [x]

Suggestions (non-blocking)

#134 — ftps:// scheme accepted but TLS not implemented; confusing dial failure
#135 — Missing tests for FTP package
#136 — ProbeFTP returns wrong error when both SIZE and RETR fallback fail

Closes #0032, #0033, #0034, #0035, #0036, #0037, #0038, #0039 on merge.

## Review: APPROVED ### Verification - `go vet ./...` — ✅ passes - `go build ./...` — ✅ passes - `golangci-lint v2 run ./...` — ✅ 0 issues ### Changes - `internal/downloader/ftp.go` (new, 171 lines) — FTP client: URL parsing, dial/login, SIZE/REST probe, range download, single download, ftpReadCloser wrapper - `ROADMAP.md` — Marks Phase 2 FTP items as [x] ### Suggestions (non-blocking) - #134 — `ftps://` scheme accepted but TLS not implemented; confusing dial failure - #135 — Missing tests for FTP package - #136 — `ProbeFTP` returns wrong error when both SIZE and RETR fallback fail Closes #0032, #0033, #0034, #0035, #0036, #0037, #0038, #0039 on merge.

fuzzy merged commit 96d10209d1 into main

2026-07-13 18:04:47 +00:00

fuzzy deleted branch feat/ftp-client

2026-07-13 18:04:48 +00:00

automation referenced this pull request

2026-07-14 08:02:49 +00:00

Parse ftp://user:pass@host/path URLs #94